eMuleFuture

I'm not CA "guru" (and as far as eMule programming - I'm probably not a "guru" of any peace of code), however :

I think there's a miss in some 0.49a mods with CA around collect spammer data -

it should be shifted from CChatSelector::ProcessMessage to CUpDownClient::ProcessChatMessage and CUpDownClient::ProcessMuleCommentPacket

focusing around SetSpammer(true) with an addition for empty str.


-- anyway this is the way I implemented it in my "mod generation" (aka "platform")

If you check the CVS then you will see that I changed that already... I didn't merge it but Dlarge and he doesn't know my code like I do

If you check the CVS then you will see that I changed that already... I didn't merge it but Dlarge and he doesn't know my code like I do

Now I see - however why the collection is dependent on thePrefs.IsAdvSpamfilterEnabled() ?

(it wasn't in the past, nor in the way I changed it)

I didn't check it in detail and I have a lot of changes here that I haven't checked in, yet... so it might already be solved

I didn't check it in detail and I have a lot of changes here that I haven't checked in, yet... so it might already be solved

If it's going to stay as is (i.e. corelated with SetSpammer(true)) it might be worth shifting it into SetSpammer - that way a single point to maintain ...